Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(route): expose performRequest func #3012

Merged
merged 1 commit into from
Jan 2, 2022
Merged

test(route): expose performRequest func #3012

merged 1 commit into from
Jan 2, 2022

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Jan 2, 2022

There are many packages that need to testing gin router like as below:

https://github.com/gin-contrib/static/blob/0b63c38653d9941a7851807d76e2692655cf6fc7/static_test.go#L16-L21

So we can expose the performRequest function.

@appleboy appleboy added the test label Jan 2, 2022
@appleboy appleboy added this to the v1.8 milestone Jan 2, 2022
@appleboy appleboy requested a review from thinkerou January 2, 2022 06:13
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #3012 (5d82745) into master (0136319) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          41       41           
  Lines        3084     3084           
=======================================
  Hits         3041     3041           
  Misses         30       30           
  Partials       13       13           
Flag Coverage Δ
go-1.13 ∅ <ø> (∅)
go-1.14 ∅ <ø> (∅)
go-1.15 ∅ <ø> (∅)
go-1.16 98.60% <ø> (ø)
go-1.17 98.50% <ø> (ø)
macos-latest 98.60% <ø> (ø)
nomsgpack 98.58% <ø> (ø)
ubuntu-latest 98.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0136319...5d82745. Read the comment docs.

Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit 94153d1 into master Jan 2, 2022
@appleboy appleboy deleted the testing branch March 17, 2022 03:18
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants