Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the path params slice out of range with the wrong latest node #2820

Closed
wants to merge 2 commits into from
Closed

Fix the path params slice out of range with the wrong latest node #2820

wants to merge 2 commits into from

Commits on Aug 13, 2021

  1. Fix params would out of range with the wrong latest node 

    getValue didn't update the latest node after walking through
the path and may regard the static route as the param type,
but the params cap was prealloc and cause out of range.

For Example:

the route was "/a/b/:c/d" and we send the request path "/a/b/c/d1",
the params cap was 1 but the `d` would also be regarded as param then
would be out of range.
    @git-hulk
    git-hulk committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    7a16098 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Add integration test case

    @git-hulk
    git-hulk committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    a1f62a5 View commit details
    Browse the repository at this point in the history