Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method LoadHTMLFilesRecursively for recursively load template files in a folder #2328

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

KimGenius
Copy link

#1296

fixed the conflicts!

@thinkerou thinkerou added this to the 1.7 milestone May 5, 2020
@thinkerou
Copy link
Member

error:

# github.com/gin-gonic/gin [github.com/gin-gonic/gin.test]
./gin_test.go:61:6: setupHTMLFiles redeclared in this block
	previous declaration at ./gin_test.go:28:85
./gin_test.go:62:5: setupHTMLFiles.func1 redeclared in this block
	previous declaration at ./gin_test.go:33:19
./gin_test.go:70:23: setupHTMLFiles.func1.1 redeclared in this block
	previous declaration at ./gin_test.go:40:23
./gin_test.go:73:22: setupHTMLFiles.func1.2 redeclared in this block
	previous declaration at ./gin_test.go:43:22
./gin_test.go:233:22: too many arguments in call to setupHTMLFiles
	have (*testing.T, string, bool, func(*Engine))
	want (*testing.T, string, bool)
./gin_test.go:241:10: ts.Close undefined (type func() has no field or method Close)
./gin_test.go:243:48: ts.URL undefined (type func() has no field or method URL)
./gin_test.go:253:22: too many arguments in call to setupHTMLFiles
	have (*testing.T, string, bool, func(*Engine))
	want (*testing.T, string, bool)
./gin_test.go:261:10: ts.Close undefined (type func() has no field or method Close)
./gin_test.go:263:48: ts.URL undefined (type func() has no field or method URL)
./gin_test.go:263:48: too many errors
FAIL	github.com/gin-gonic/gin [build failed]
FAIL
Makefile:11: recipe for target 'test' failed
make: *** [test] Error 1
The command "make test" exited with 2.

@locnguyen
Copy link

@KimGenius I'd love to see this PR merged soon!

@4n70w4
Copy link

4n70w4 commented Apr 24, 2021

Hi! Any news?

@thinkerou
Copy link
Member

Hi! Any news?

@KimGenius please fix error: https://travis-ci.org/github/gin-gonic/gin/jobs/768698874, thanks!

@KimGenius
Copy link
Author

KimGenius commented Jun 14, 2021

Sorry everybody
I will fix error in few days
Thank you!

@zzjin
Copy link
Contributor

zzjin commented Aug 22, 2021

any update here?

@thinkerou thinkerou modified the milestones: v1.8, v1.9 Nov 21, 2021
@yanislav-igonin
Copy link

few days lol

@thinkerou thinkerou removed this from the v1.9 milestone Jan 17, 2023
@thinkerou thinkerou added this to the v1.10 milestone Jan 17, 2023
@appleboy appleboy modified the milestones: v1.10, v1.11 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants