Skip to content

Conversation

@DeathKing
Copy link
Contributor

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integrations systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1868 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          41       41           
  Lines        2149     2149           
=======================================
  Hits         2120     2120           
  Misses         18       18           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11407e7...c268193. Read the comment docs.

@thinkerou thinkerou self-requested a review April 24, 2019 10:29
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thinkerou thinkerou merged commit 202f8fc into gin-gonic:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants