-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use camel case instead of ALL_CAPS #1419
Conversation
7259972
to
c88d36b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 41 41
Lines 2049 2049
=======================================
Hits 2018 2018
Misses 19 19
Partials 12 12
Continue to review full report at Codecov.
|
it will break forward compatibility. |
@thinkerou well, should I close? |
@crispgm sorry, I understand error, it not break, because set environment var using |
@crispgm maybe we should use |
@thinkerou Nope, mixed caps is the common practice for constants, which is used by go linters. |
ENV_GIN_MODE -> EnvGinMode