Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use camel case instead of ALL_CAPS #1419

Merged
merged 7 commits into from
Feb 22, 2019

Conversation

crispgm
Copy link
Contributor

@crispgm crispgm commented Jul 2, 2018

ENV_GIN_MODE -> EnvGinMode

@crispgm crispgm force-pushed the camel-case-env-mode branch from 7259972 to c88d36b Compare July 2, 2018 07:54
@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #1419 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1419   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          41       41           
  Lines        2049     2049           
=======================================
  Hits         2018     2018           
  Misses         19       19           
  Partials       12       12
Impacted Files Coverage Δ
mode.go 90.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f6c61...7e9d93e. Read the comment docs.

@thinkerou
Copy link
Member

it will break forward compatibility.

@crispgm
Copy link
Contributor Author

crispgm commented Jul 2, 2018

@thinkerou well, should I close?

@thinkerou
Copy link
Member

@crispgm sorry, I understand error, it not break, because set environment var using GIN_MODE, so not close, need cr, thanks!

@thinkerou
Copy link
Member

@crispgm maybe we should use ALL_CAPS for const, https://github.com/Unknwon/go-code-convention/blob/master/en-US/naming_rules.md#constants, but I not find the official document.

@crispgm
Copy link
Contributor Author

crispgm commented Jul 2, 2018

@thinkerou Nope, mixed caps is the common practice for constants, which is used by go linters.
See https://github.com/golang/go/wiki/CodeReviewComments#mixed-caps.
And this is what we do in other packages. :)

@thinkerou thinkerou merged commit d7daffc into gin-gonic:master Feb 22, 2019
@crispgm crispgm deleted the camel-case-env-mode branch February 24, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants