support bind http header param

[guonaihong]

When I refactored some services, I found that gin does not have a function that binds the http header. I think it would be very good if I had this function.

package main

import (
	"fmt"
	"github.com/gin-gonic/gin"
)

type testHeader struct {
	Rate   int    `header:"Rate"`
	Domain string `header:"Domain"`
}

func main() {
	r := gin.Default()
	r.GET("/", func(c *gin.Context) {
		h := testHeader{}

		if err := c.ShouldBindHeader(&h); err != nil {
			c.JSON(200, err)
		}

		fmt.Printf("%#v\n", h)
		c.JSON(200, gin.H{"Rate": h.Rate, "Domain": h.Domain})
	})

	r.Run()
}

[Askadias]

Could you please push it to release?

[guonaihong]

Now the master branch has the ShoudBindHeader function.

[xxiaocheng]

.

How can I use it with the go module. It still can't be used when I use import "github.com/gin-gonic/gin". Thank you.

[guonaihong]

The v1.5 version does not come out, the temporary method can specify the commit id。

Edit the go.mod file

require github.com/gin-gonic/gin db9174ae0c2587fe1c755def0f88cb9aba9e9641

[xxiaocheng]

The v1.5 version does not come out, the temporary method can specify the commit id。

Edit the go.mod file

require github.com/gin-gonic/gin db9174ae0c2587fe1c755def0f88cb9aba9e9641

Thank you very much. It work for me now.

[xxiaocheng]

I can do it here. You look at my complete process

Create a working directory

mkdir use_gin && cd use_gin/
go mod init demo

edit go.mod

module demo

go 1.13

require github.com/gin-gonic/gin db9174ae0c2587fe1c755def0f88cb9aba9e9641

edit demo.go

package main

import (
	"fmt"
	"github.com/gin-gonic/gin"
)

type header struct {
	Page int `header:"page"`
	Size int `header:"size"`
}

func main() {
	g := gin.Default()
	g.GET("/", func(c *gin.Context) {
		h := header{}
		err := c.ShouldBindHeader(&h)
		if err != nil {
			fmt.Printf("fail:%s\n", err)
			return
		}

		c.JSON(200, h)
	})

	g.Run()
}

run demo

env GOPROXY=https://goproxy.cn go run demo.go

Success log

go: finding github.com/gin-gonic/gin db9174ae0c2587fe1c755def0f88cb9aba9e9641
[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.

[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.
 - using env:	export GIN_MODE=release
 - using code:	gin.SetMode(gin.ReleaseMode)

[GIN-debug] GET    /                         --> main.main.func1 (3 handlers)
[GIN-debug] Environment variable PORT is undefined. Using port :8080 by default
[GIN-debug] Listening and serving HTTP on :8080

The vscode can't recognize this function just now. But it already work for me I think maybe its vscodes bug,

[guonaihong]

ok

[guonaihong]

I have time tomorrow to look at your question. 

…

---Original--- From: "Saurabh Gupta"<notifications@github.com&gt; Date: Mon, Mar 30, 2020 18:43 PM To: "gin-gonic/gin"<gin@noreply.github.com&gt;; Cc: "State change"<state_change@noreply.github.com&gt;;"guonaihong"<guonaihong@qq.com&gt;; Subject: Re: [gin-gonic/gin] support bind http header param (#1956) ShouldBindHeader function is not binding according to json parameters in struct(As with other bindings). Rather its getting bind to golang names defined in the struct. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.