Simplify code (#2004)

- Use buf.String instead of converison - Remove redundant return
gin-gonic · Jul 27, 2019 · 461df93 · 461df93
1 parent 502c898
commit 461df93
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/gin.go b/gin.go
@@ -437,7 +437,6 @@ func serveError(c *Context, code int, defaultMessage []byte) {
 		return
 	}
 	c.writermem.WriteHeaderNow()
-	return
 }
 
 func redirectTrailingSlash(c *Context) {

diff --git a/render/render_test.go b/render/render_test.go
@@ -45,7 +45,7 @@ func TestRenderMsgPack(t *testing.T) {
 	err = codec.NewEncoder(buf, h).Encode(data)
 
 	assert.NoError(t, err)
-	assert.Equal(t, w.Body.String(), string(buf.Bytes()))
+	assert.Equal(t, w.Body.String(), buf.String())
 	assert.Equal(t, "application/msgpack; charset=utf-8", w.Header().Get("Content-Type"))
 }