Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(options): Added availability to set 200/204 for OPTIONS request status #129

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

dkischenko
Copy link
Contributor

Just small fix to support old devices that's can't process 204 status code.

@dkischenko dkischenko marked this pull request as ready for review November 10, 2023 13:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee4df80) 94.03% compared to head (d9d3b88) 94.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   94.03%   94.14%   +0.10%     
==========================================
  Files           3        3              
  Lines         218      222       +4     
==========================================
+ Hits          205      209       +4     
  Misses         12       12              
  Partials        1        1              
Flag Coverage Δ
go- 94.14% <100.00%> (+0.10%) ⬆️
go-1.18 94.14% <100.00%> (+0.10%) ⬆️
go-1.19 94.14% <100.00%> (+0.10%) ⬆️
go-1.20 94.14% <100.00%> (+0.10%) ⬆️
go-1.21 94.14% <100.00%> (+0.10%) ⬆️
macos-latest 94.14% <100.00%> (+0.10%) ⬆️
ubuntu-latest 94.14% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy changed the title Added availability to set 200/204 for OPTIONS request status chore(options): Added availability to set 200/204 for OPTIONS request status Nov 25, 2023
@appleboy appleboy merged commit f8b2357 into gin-contrib:master Nov 25, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants