Add SHT_LLVM_DEPENDENT_LIBRARIES #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Yes this approach is good (maybe in future we want to add something generic for SHF_STRINGS sections instead), but can you move it up with the SHT_PROGBITS arm, and also add to
object/crates/examples/src/readobj/elf.rs
Line 1358 in b25fb7f
purplesyringa
force-pushed
the
llvm-dependent-libraries
branch
from
d90a534
to
7cbb0c4
Compare
|
Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen this section in some binaries linked with clang.
Builderunderstandably denied parsing the ELF due to an unknown section, so here we go.There's some docs for it and it seems easy to parse, but AFAIK notes aren't parsed and no one's angry about that, so I'm leaving this as
Data.Does this approach look okay?