Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.36.4 #724

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Release 0.36.4 #724

merged 5 commits into from
Aug 30, 2024

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Aug 29, 2024

No description provided.

@marxin
Copy link
Contributor

marxin commented Aug 29, 2024

Btw. I tried building the current main branch of the Wild linker and I met the following warning:

warning: associated function `new` is never used
   --> /home/marxin/Programming/object/src/read/mod.rs:600:8
    |
599 | impl<'data> ObjectMapFile<'data> {
    | -------------------------------- associated function in this implementation
600 |     fn new(path: &'data [u8], member: Option<&'data [u8]>) -> Self {
    |        ^^^
    |
    = note: `#[warn(dead_code)]` on by default

Is it something expected or did I mess something?

@marxin
Copy link
Contributor

marxin commented Aug 29, 2024

Got it, it's related to the fact that wild does not use macho feature flag, which is the only place that uses the new function.

@philipc
Copy link
Contributor Author

philipc commented Aug 30, 2024

Thanks for pointing that out.

@philipc philipc merged commit 8469876 into gimli-rs:master Aug 30, 2024
10 checks passed
@philipc philipc deleted the release branch August 30, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants