Skip to content

add support for csky arch(elf)#561

Merged
philipc merged 3 commits into
gimli-rs:masterfrom
Dirreke:csky-elf
Jul 18, 2023
Merged

add support for csky arch(elf)#561
philipc merged 3 commits into
gimli-rs:masterfrom
Dirreke:csky-elf

Conversation

@Dirreke
Copy link
Copy Markdown
Contributor

@Dirreke Dirreke commented Jul 14, 2023

No description provided.

@bjorn3
Copy link
Copy Markdown
Contributor

bjorn3 commented Jul 14, 2023

All matches seem to be sorted by variant name. Could you insert the Csky variant at the right place to keep it sorted?

Comment thread src/common.rs Outdated
Wasm32,
Wasm64,
Xtensa,
CSKY,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CSKY,
Csky,

Rustc warns about non-CamelCase names.

Copy link
Copy Markdown
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please also add support in these two places:

fn architecture(&self) -> Architecture {

fn elf_any() {

@philipc philipc merged commit 5754050 into gimli-rs:master Jul 18, 2023
poliorcetics pushed a commit to JustRustThings/object that referenced this pull request Jul 24, 2023
@Dirreke
Copy link
Copy Markdown
Contributor Author

Dirreke commented Jul 29, 2023

When will the next version be released

@philipc
Copy link
Copy Markdown
Contributor

philipc commented Jul 29, 2023

I don't think there's been any breaking changes yet, so I can do a point release when needed.

@philipc
Copy link
Copy Markdown
Contributor

philipc commented Aug 13, 2023

0.32.0 has been published.

mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants