Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read/coff: Add support for extended relocations. #399

Merged
merged 7 commits into from
Nov 20, 2021

Conversation

osiewicz
Copy link
Contributor

Fixes #177.

@osiewicz
Copy link
Contributor Author

Okay, so some of these scenarios do fail due to desync with testfiles. I guess we'd have to either build test files on CI or commit them into the repository.

src/read/coff/section.rs Outdated Show resolved Hide resolved
tests/coff.rs Show resolved Hide resolved
@philipc
Copy link
Contributor

philipc commented Nov 18, 2021

Okay, so some of these scenarios do fail due to desync with testfiles. I guess we'd have to either build test files on CI or commit them into the repository.

The intent was to commit them into the repository, which is why it was made a separate repository.

src/read/coff/section.rs Outdated Show resolved Hide resolved
@philipc philipc merged commit ffaf0de into gimli-rs:master Nov 20, 2021
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pe/coff don't handle IMAGE_SCN_LNK_NRELOC_OVFL
2 participants