read: add support for custom address types #735
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preemptively allow complex types that result from adding an associated type for addresses.
Add the `Reader::Address` associated type, which implements the
`ReaderAddress` trait. This trait is implemented for u64 to
provide the existing behaviour of supporting multiple address sizes,
as well as for `Address32` and `Address64` which support a single
address size.
The dwarfdump example now provides its own address type, which
allows it to show symbols associated with relocated addresses
in relocatable object files.
For example:
DW_AT_low_pc main+0x0
DW_AT_ranges <rnglist at .debug_rnglists+0x0000000c>
[ 0] <start-length main+0x0, 0x17> [main+0x0, main+0x17]
DW_LNE_set_address to main+0x0
|
This is a breaking change, and adds significant complexity. While I think the dwarfdump support is neat, I'm not completely convinced it is worth it, so I'm going to leave this as a draft for while. To do:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Reader::Addressassociated type, which implements theReaderAddresstrait. This trait is implemented for u64 to provide the existing behaviour of supporting multiple address sizes, as well as forAddress32andAddress64which support a single address size.The dwarfdump example now provides its own address type, which allows it to show symbols associated with relocated addresses in relocatable object files. For example:
Closes #409