Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operations for mutate write::DebuggingInformationEntry #374

Open
yurydelendik opened this issue Feb 1, 2019 · 1 comment
Open

Add operations for mutate write::DebuggingInformationEntry #374

yurydelendik opened this issue Feb 1, 2019 · 1 comment

Comments

@yurydelendik
Copy link
Contributor

Are there operations for remove the child DIE or attributes? It will be useful to have such operations to mutate in-memory UnitTable forest.

@philipc
Copy link
Collaborator

philipc commented Feb 2, 2019

Not yet, but we definitely want them.

For DIEs, removing them just needs to update the children field of the parent, without actually deleting the child from the entries Vec. Attributes can simply be deleted.

One catch with that will be if a deleted attribute referenced something in another table (strings or range lists), then we'll still write those values out (deleting them from the other tables isn't easy). I don't have a solution for that yet.

@philipc philipc mentioned this issue Feb 20, 2019
10 tasks
ayrtonm added a commit to ayrtonm/gimli that referenced this issue Jul 23, 2021
Children DIEs are delete by removing the ID from the `children` `Vec` as
suggested in issue gimli-rs#374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants