Fix stderr draining from child process - #13
Merged
Conversation
gilfree
approved these changes
May 24, 2026
Owner
|
@ksuszka see if it works for you, if it does let me know and I'll publish a new release? |
Contributor
Author
|
@gilfree I just used master version and it seems to work fine. My tests generated a few hundreds MB of output without hanging. |
Owner
|
@ksuszka sorry for not releasing yet, pypi had added some security hooks I don't know how to jump yet. Hope to find time to try this again in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that with
--isolate --capture=tee-sysmy tests hanged after some time. After some investigation I discovered that stderr buffer was full as it was not read. This change should fix it.