a browser keyboard shortcut for saving the complete page

[user-1-2-3-4-5]

Is your feature request related to a problem? Please describe.

The 'save the selected tabs or their selected contents' hotkey partially saves a webpage when any part is highlighted, as expected — I frequently save incomplete pages by mistake after having selected text.

The only other available hotkey is the 'save all tabs' feature, seldom used by me.

Describe the solution you'd like

Please add another hotkey for 'save the page with Singlefile' context menu option (see the screenshot below). This is the only extension option I currently actively use and my workflow would benefit from a hotkey.

The custom shortcuts seemingly can't be used beyond mapping to specific Singlefile profiles.

Describe alternatives you've considered (optional)

Additional context (optional)

[gildas-lormeau]

I agree that it would be useful to have a shortcut for this. Do you have any suggestions (once again, sorry)?

[user-1-2-3-4-5]

I agree that it would be useful to have a shortcut for this. Do you have any suggestions (once again, sorry)?

Ctrl + Alt + F is available in Firefox, and makes some sense since F can be derived from the name Singlefile.

Some of the function keys are also free, e.g. F1 and F2.

---

I've already suggested Ctrl + Alt + S to replace a non-functional default mapping. Thankfully Firefox allows customising the extension shortcuts, thus the defaults aren't as vitally important.

[InvaderGIT]

Strongly agree that a shortcut is needed for this. I wonder how many pages I've accidentally saved only a selection from. Once added, please be sure it's clear in the documentation that the Ctrl + Shift + Y will only save a selection, if you happen to have one somewhere on the page. Right now, it doesn't appear to mention that anywhere. ("About this extension" on the addons site just says "You can use the customizable shortcut Ctrl+Shift+Y to save the current tab or selected tabs.").

Would prefer a shortcut that can be typed with just my left hand, without having to stretch painfully like with Ctrl + Shift + Y. Ctrl + Alt + S would be easy to type, and more intuitive than "Y".

[user-1-2-3-4-5]

Also, forgoing default shortcut mappings entirely is plausible — given that the top Firefox addon uBlock Origin has never had any to my knowledge (there's eight in total, at the time).

[aplaice]

Custom shortcuts workaround

This isn't a solution to the issue of having a default shortcut for saving the full page, but (contrary to what's suggested in an earlier comment) you already can use the custom shortcuts to achieve this.

If you set a custom shortcut and assign it to a profile (including the default profile) then pressing that shortcut will always save the full page irrespective of whether text is highlighted or not.

See:

https://github.com/gildas-lormeau/SingleFile//blob/master/src/ui/bg/ui-commands.js#L50-L64

(Compare the action for save-selected-tabs (business.saveTabs(highlightedTabs, { optionallySelected: true });) and for custom-command-* (business.saveTabs(highlightedTabs, profiles[selectedProfile]);).)

(I've also explicitly tested that the custom shortcuts and the "Save the selected tabs or their selected contents" shortcut do indeed behave differently in this respect.)

(Commenting because I was also bitten by the issue of having unintentionally saved pages with the selection active and decided to investigate.) (I don't have a strong opinion on whether a default keybinding for "always save the entire page" is needed given that the custom shortcuts do work for this.)

---

UI for assigning custom shortcuts

(This is tangentially related to the current issue and is itself debatable and very minor, so I'm commenting here rather than opening a new issue. Sorry if this is wrong!)

IMO the UI for assigning the custom shortcuts to a profile (Preferences > {selection of profile} > User interface > keyboard shortcut command) is slightly confusing.

It solves the difficult problem of allowing one to match the shortcuts set via Firefox's manage shortcuts UI (which is rigidly pre-defined via the manifest) to profiles (which are user-defined) so some of the complexity is unfortunately unavoidable.

However, I think that having "default shortcut" in the drop-down for the keyboard shortcut command is confusing.

1. The default shortcut ("Save the selected tabs or their selected contents") will, I believe, always use the default profile irrespective of whether:

   a) a different keyboard shortcut command ("Custom shortcut #X") is set for the default profile

   b) a different profile has "default shortcut" set for another profile

2. The default shortcut and the custom shortcuts differ in their behaviour wrt to selected contents, so placing them in the same drop-down leads to confusion — it suggests that the custom shortcuts also saves only the selected contents if there is any.

Unfortunately, I'm not sure what's the best alternative for the no custom shortcut key set, case. Maybe something like "no additional shortcut" with a note in the "help" (i) section that the default profile can always still be "accessed" via the "Save the selected tabs or their selected contents" shorcut??

---

Thanks

P.S. I'm a gigantic fan of the SingleFile extension. Thanks so much for having developed it!

[user-1-2-3-4-5]

Custom shortcuts workaround

This isn't a solution to the issue of having a default shortcut for saving the full page, but (contrary to what's suggested in an earlier comment) you already can use the custom shortcuts to achieve this.

If you set a custom shortcut and assign it to a profile (including the default profile) then pressing that shortcut will always save the full page irrespective of whether text is highlighted or not.

After minimal testing, this appears to be correct. No more wrong (any link selected — common when navigating with the keyboard) and near-blank (saving when text is highlighted) pages!

instructions

1. enable a custom shortcut in the Singlefile preferences:

2. in about:addons (Firefox) → 'manage extension shortcuts', assign one to Singlefile:

---

I agree that the process is confusing and could be streamlined in some form.