Skip to content

Conversation

fabb
Copy link

@fabb fabb commented May 14, 2025

fixes #1121

Copy link

codesandbox bot commented May 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@fabb fabb changed the base branch from main to next May 14, 2025 15:45
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jdhenry08
Copy link

@fabb @gilbarbara Can we get this merged? It's affecting a project of mine (among others who have commented or subscribed to the linked issue).

@sjorsverhoef
Copy link

sjorsverhoef commented Sep 26, 2025

Hi @gilbarbara

I hope you're doing well! I wanted to follow up on PR #1172, which addresses the issue with skipProps.onClick not triggering the callback (related to issue #1121).

We're currently experiencing this bug in our production application, and this PR appears to provide the exact fix we need. The solution looks solid based on the discussion in the thread.

Would it be possible to get this merged in an upcoming release? We'd be happy to help with testing or any additional changes needed.

Thank you for your time and for maintaining this excellent library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback not fired when skipping first step in react-joyride
3 participants