setters.py -> set_string() -> isascii() #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scii(). Siemens allows ascii 0-255.
gijzelaerr
approved these changes
Apr 20, 2025
setters.py -> set_char() was limited to ascii 0-128 because of .isascii(). Siemens allows ascii 0-255.
Contributor
Author
|
Function snap7.util.set_char() was not automatically imported. |
Contributor
Author
|
set_char() should not return Union[ValueError, bytearray], just bytearray |
Contributor
Author
|
changed ValueError message in set_string() |
…ons and symlinks correctly. Add a step to unlink any existing Python versions before installing the required version and explicitly link the newly installed version
Contributor
Author
|
adjusted the workflow to ensure that Homebrew handles Python installations and symlinks correctly. Added a step to unlink any existing Python versions before installing the required version and explicitly link the newly installed version |
gijzelaerr
requested changes
Apr 29, 2025
gijzelaerr
approved these changes
Apr 29, 2025
Owner
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setters.py -> set_string() was limited to ascii 0-128 because of .isascii().
Siemens allows ascii 0-255.