Prepare deploy sample implementation (public repo) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plsr
reviewed
Apr 25, 2024
Comment on lines
+20
to
+28
| const privateEnvVars = { | ||
| APP_ENV: process.env.APP_ENV, | ||
| GIGS_PROJECT: process.env.GIGS_PROJECT, | ||
| GIGS_API_KEY: process.env.GIGS_API_KEY, | ||
| } | ||
|
|
||
| export function injectPrivateEnvVars() { | ||
| Object.assign(process.env, privateEnvVars) | ||
| } |
There was a problem hiding this comment.
I don't really understand what this does and why we need it 🙈
There was a problem hiding this comment.
I think I answered my question myself by missing to add this in the Tracking PR in the API Docs 😅
There was a problem hiding this comment.
Totally missed that question 😅 It's to ensure that relevant env variables are accessible when the project is built and running somewhere (or at least that's my understanding)
3nvi
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of the plan
This is the first step, adding a docker to public example repo