-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Transactions List Endpoint to existing Airbyte Connector #1
base: master
Are you sure you want to change the base?
Conversation
4b00102
to
832abb7
Compare
@Harmaton I'm attempting to build the However, when attempting to retrieve the schema (creating a connection), it fails. See attached log dump of the exeception. Switching the connector version back to FWIW: I rebased this branch with latest /cc @revans |
@@ -70,6 +70,7 @@ | |||
VendorSalesReports, | |||
VendorTrafficReport, | |||
XmlAllOrdersDataByOrderDataGeneral, | |||
ListTransactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to name this stream FinanceTransactions
instead of ListTransactions
? Feels like ListTransactions
is a little ambiguous. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind temporarily providing me with credentials so I can generate the exact schema I wish to get ? Its quite large and complex to do manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harmaton I can't provide any live credentials, sorry. I was just researching how to provide sandbox access. I'm unfamiliar with seller central sandbox, so not sure exactly how to grant access yet. However, it seems the sandbox just responds with a "mocked" response. The finance mocked response comes from github here: https://github.com/amzn/selling-partner-api-models/blob/main/models/finances-api-model/finances_2024-06-19.json
Is that something you could use? I will continue looking at how to provide temporary sandbox credentials and reply when I have something to share.
Use the following Instruction to run the tests. I made a few changes to fix the schema issues causing the error. I decided to keep the prior naming to match the amazon documentation naming. Here is the Spec.json file to help with config for local dev. Thanks! |
Awesome, will try again running locally and report back. Thanks! |
@Harmaton after rebuilding from latest, still seems to be having same issue. 🤔 |
I updated the schema in the code with the reference to the json schema in the documentation. Please run this test. I atleast expect a different error if any. Iam almost done securing my own credentials if I need to do any other test on my end. Thanks! |
@Harmaton I was able to get the schema to run now, however it doesn't look correct. Missing fields and why would pagination |
I spotted the error and fixed it with the latest commit. |
I would appreciate if you could please run the LAST test for me. If it does not sync then I will get to use my credentials by tomorrow. I am however confident this was the last iteration . @zerobearing2 |
…ields) and added the startfield required field (which caused the error)
@zerobearing2 Can you confirm that you can now see the field listings ? |
replied in slack |
What
This PR introduces a new endpoint to retrieve a list of transactions from the amazon seller api. It addresses the need for users to view their transaction history efficiently and provides proper documentation and configuration for the new feature.
How
ListTransaction.json
to handle GET requests for transaction listsstreams.py
source.py