Repository navigation
feat(credprovider): a provider bounds how long the injector reuses its answer - #110
Draft
QuentinBisson wants to merge 2 commits into
Draft
QuentinBisson wants to merge 2 commits into
QuentinBisson wants to merge 2 commits into
Conversation
Author
|
Parked: git as the person is postponed. Upstream Substrate is redesigning this area (actor JWT injection merged in agent-substrate#1960, token exchange of the actor JWT in agent-substrate#1661, the actor JWT contract in agent-substrate#1756), which likely supersedes this provider design, and this fork line has to re-pin past agent-substrate#1809 before it can follow. Kept as a draft so it can resume in place; tracking in giantswarm/giantswarm#38064. |
QuentinBisson
force-pushed
the
giantswarm
branch
from
October 5, 2026 20:46
90dc3ba to
e27ae95
Compare
heraldbot
Bot
force-pushed
the
giantswarm
branch
from
October 8, 2026 20:21
8a25c47 to
85d02ec
Compare
…s answer FetchSecretResponse.max_age: unset keeps the injector's default, zero makes it fetch the secret again for every request, and an injector never reuses an answer past its own default. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
…l cache The Kubernetes provider guide described the egress gateway's five-minute credential cache as fixed. FetchSecretResponse.max_age lets a provider shorten it, down to a fetch for every request. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
feat/credential-max-age
branch
from
October 8, 2026 21:31
92cd40b to
ebbcdd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The egress gateway's injector reuses a fetched secret for the same actor and URI for as long as it likes. A provider whose answer depends on who is acting on the actor right now (kagent answering with the token of the person whose turn runs) cannot say "this answer is good for this request only".
Change
FetchSecretResponse.max_age: unset keeps the injector's default, zero makes it fetch again for every request, and no injector reuses an answer past its own default. atenet's Go injector keeps no cache, so it already honours zero; agentgateway's cache honours the field in giantswarm/agentgateway-upstream#37. Towards giantswarm/giantswarm#38056.