Repository navigation
docs(fork): name the queue rows of the artifact credential exits - #368
Merged
Merged
Conversation
Signed-off-by: Timo Derstappen <teemow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/giantswarm#38341.
Problem
The two
fork/carried/files of the artifact credential still pointed at the line's closed upstream draft (kagent-dev#2899) and at no queue row for the golden-only scope, so the ledger did not say how either patch leaves the line.Proposed solution
egress-keep-artifact-credentials-off-a-sessions.md(the Session-policy patch, feat(egress): keep artifact credentials off a Session's egress policy #366): its upstream cell names the exit, the golden-time follow-up the review note on feat(skills): private Git skill sources via egress gateway credentials kagent-dev/kagent#3099 names, prepared as anupstream/…branch on the mirror plus feat(skills): private Git skill sources via egress gateway credentials kagent-dev/kagent#3099's head once feat(skills): private Git skill sources via egress gateway credentials kagent-dev/kagent#3099 is merged, after Configure egress access during golden initialization agent-substrate/substrate#2159 and Trigger CI workflows on all release/** branches kagent-dev/kagent#2117, and the queue row giantswarm/giantswarm#37742 row 170.api-a-per-source-credential-for-private-git.md(credentialRef): its upstream cell names feat(skills): private Git skill sources via egress gateway credentials kagent-dev/kagent#3099 (authorizationFrom, which replaced feat(api): a per-source credential for private git skill and plugin sources kagent-dev/kagent#2899) and what the re-pin that carries it adopts, row 4.Documentation only: a
docs(fork):commit cuts no release; it ships with the next candidate.Acceptance criteria
fork/carried/file names row 170 and the exit.upstream/…branch yet: row 170 names feat(skills): private Git skill sources via egress gateway credentials kagent-dev/kagent#3099's state and the Substrate pull requests it waits on.