Skip to content

Set conditions to true when reconciliation is successful #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release-2.7
Choose a base branch
from
Draft

Set conditions to true when reconciliation is successful #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cloud/services/network/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,48 +42,56 @@ func (s *Service) ReconcileNetwork() (err error) {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.SecondaryCidrsReadyCondition, infrav1.SecondaryCidrReconciliationFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.SecondaryCidrsReadyCondition)

// Subnets.
if err := s.reconcileSubnets(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.SubnetsReadyCondition, infrav1.SubnetsReconciliationFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.SubnetsReadyCondition)

// Internet Gateways.
if err := s.reconcileInternetGateways(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.InternetGatewayReadyCondition, infrav1.InternetGatewayFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.InternetGatewayReadyCondition)

// Carrier Gateway.
if err := s.reconcileCarrierGateway(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.CarrierGatewayReadyCondition, infrav1.CarrierGatewayFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.CarrierGatewayReadyCondition)

// Egress Only Internet Gateways.
if err := s.reconcileEgressOnlyInternetGateways(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.EgressOnlyInternetGatewayReadyCondition, infrav1.EgressOnlyInternetGatewayFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.EgressOnlyInternetGatewayReadyCondition)

// NAT Gateways.
if err := s.reconcileNatGateways(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.NatGatewaysReadyCondition, infrav1.NatGatewaysReconciliationFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.NatGatewaysReadyCondition)

// Routing tables.
if err := s.reconcileRouteTables(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.RouteTablesReadyCondition, infrav1.RouteTableReconciliationFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.RouteTablesReadyCondition)

// VPC Endpoints.
if err := s.reconcileVPCEndpoints(); err != nil {
conditions.MarkFalse(s.scope.InfraCluster(), infrav1.VpcEndpointsReadyCondition, infrav1.VpcEndpointsReconciliationFailedReason, infrautilconditions.ErrorConditionAfterInit(s.scope.ClusterObj()), err.Error())
return err
}
conditions.MarkTrue(s.scope.InfraCluster(), infrav1.VpcEndpointsReadyCondition)

s.scope.Debug("Reconcile network completed successfully")
return nil
Expand Down
Loading