Skip to content

🐛 Don't put tags from AWS subnet into the subnetSpec #26

🐛 Don't put tags from AWS subnet into the subnetSpec

🐛 Don't put tags from AWS subnet into the subnetSpec #26

Triggered via pull request October 21, 2024 10:31
Status Failure
Total duration 5m 35s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 4 warnings
lint: pkg/cloud/services/network/subnets_test.go#L66
undefined: slices.Concat (typecheck)
lint: exp/controllers/awsmachinepool_controller.go#L416
declaration has 3 blank identifiers (dogsled)
lint: pkg/cloud/services/s3/s3.go#L540
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: pkg/cloud/services/ec2/launchtemplate_test.go#L88
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/autoscaling/autoscalinggroup_test.go#L1183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
lint: exp/controllers/awsmanagedmachinepool_controller.go#L224
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)
lint: pkg/cloud/services/awsnode/cni.go#L285
unnecessary trailing newline (whitespace)
lint: pkg/cloud/services/network/account.go#L1
: # sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/services/network [sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/services/network.test]
lint: pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/autoscaling/autoscalinggroup_test.go#L1183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
lint: exp/controllers/awsmanagedmachinepool_controller.go#L224
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)