Skip to content

Commit

Permalink
Switch to using Giant Swarm fork for built images, replace deprecated…
Browse files Browse the repository at this point in the history
… kustomize config `patchesStrategicMerge`
  • Loading branch information
AndiDog committed Jun 5, 2023
1 parent 531ac42 commit b36c339
Show file tree
Hide file tree
Showing 58 changed files with 550 additions and 526 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Switch to using Giant Swarm fork for built images, replace deprecated kustomize config `patchesStrategicMerge`

## [1.12.0] - 2023-05-17

### Added
Expand Down
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,8 @@ This is a meta App that provides deployment packaging for Cluster API core, boot

## Upgrading CAPI

If you want to upgrade the CAPI version used in this app, there is a value in the `values.yaml` file of the helm chart that controls which CAPI version to use.
See README of [cluster-api fork](https://github.com/giantswarm/cluster-api/blob/main/README.md) for testing and releasing changes.

Once you have changed that value, you may run `make generate` so that the app helm manifests and CRDs are regenerated using that version of CAPI.
Manifests will be generated automatically from the source manifests attached to the Github release of the selected version.
It is important to run `make generate` so that the patches, app manifests and CRDs are regenerated using the new version of CAPI.

There is one thing that needs manual intervention though. **When new webhooks are added upstream** we need to add them to the following `kustomize` patches:
- webhook-certificate.yaml
- webhook-watchfilter.yaml
There is one thing that needs manual intervention though: **when new webhooks are added upstream**, we need to manually add them to the relevant patches (`config/helm/certificate*.yaml`).
14 changes: 14 additions & 0 deletions config/helm/certificate-kubeadm-bootstrap.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: capi-kubeadm-bootstrap-serving-cert
namespace: capi-kubeadm-bootstrap-system
spec:
dnsNames:
- capi-kubeadm-bootstrap-webhook-service.{{ .Release.Namespace }}.svc
- capi-kubeadm-bootstrap-webhook-service.{{ .Release.Namespace }}.svc.cluster.local
issuerRef:
group: cert-manager.io
kind: ClusterIssuer
name: selfsigned-giantswarm
secretName: capi-kubeadm-bootstrap-webhook-service-cert
14 changes: 14 additions & 0 deletions config/helm/certificate-kubeadm-control-plane.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: capi-kubeadm-control-plane-serving-cert
namespace: capi-kubeadm-control-plane-system
spec:
dnsNames:
- capi-kubeadm-control-plane-webhook-service.{{ .Release.Namespace }}.svc
- capi-kubeadm-control-plane-webhook-service.{{ .Release.Namespace }}.svc.cluster.local
issuerRef:
group: cert-manager.io
kind: ClusterIssuer
name: selfsigned-giantswarm
secretName: capi-kubeadm-control-plane-webhook-service-cert
31 changes: 0 additions & 31 deletions config/helm/certificate.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
Expand All @@ -13,33 +12,3 @@ spec:
kind: ClusterIssuer
name: selfsigned-giantswarm
secretName: capi-webhook-service-cert
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: capi-kubeadm-control-plane-serving-cert
namespace: capi-kubeadm-control-plane-system
spec:
dnsNames:
- capi-kubeadm-control-plane-webhook-service.{{ .Release.Namespace }}.svc
- capi-kubeadm-control-plane-webhook-service.{{ .Release.Namespace }}.svc.cluster.local
issuerRef:
group: cert-manager.io
kind: ClusterIssuer
name: selfsigned-giantswarm
secretName: capi-kubeadm-control-plane-webhook-service-cert
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: capi-kubeadm-bootstrap-serving-cert
namespace: capi-kubeadm-bootstrap-system
spec:
dnsNames:
- capi-kubeadm-bootstrap-webhook-service.{{ .Release.Namespace }}.svc
- capi-kubeadm-bootstrap-webhook-service.{{ .Release.Namespace }}.svc.cluster.local
issuerRef:
group: cert-manager.io
kind: ClusterIssuer
name: selfsigned-giantswarm
secretName: capi-kubeadm-bootstrap-webhook-service-cert
22 changes: 0 additions & 22 deletions config/helm/delete-issuers.yaml

This file was deleted.

44 changes: 0 additions & 44 deletions config/helm/delete-leader-election.yaml

This file was deleted.

16 changes: 16 additions & 0 deletions config/helm/deployment-args-controller-manager.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-controller-manager
namespace: capi-system
spec:
template:
spec:
containers:
- name: manager
args:
- --metrics-bind-addr=0.0.0.0:8080
- --feature-gates=MachinePool=true,ClusterResourceSet=true,ClusterTopology=true
- --watch-filter={{ .Values.watchFilter }}
- --v=0
image: '{{.Values.images.domain}}/{{.Values.images.core.name}}:{{.Values.images.core.tag | default .Values.images.tag}}'
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-bootstrap-controller-manager
namespace: capi-kubeadm-bootstrap-system
spec:
template:
spec:
containers:
- name: manager
args:
- --metrics-bind-addr=0.0.0.0:8080
- --feature-gates=MachinePool=true,KubeadmBootstrapFormatIgnition=true
- --watch-filter={{ .Values.watchFilter }}
- --v=0
image: '{{.Values.images.domain}}/{{.Values.images.bootstrap.name}}:{{.Values.images.bootstrap.tag | default .Values.images.tag}}'
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-control-plane-controller-manager
namespace: capi-kubeadm-control-plane-system
spec:
template:
spec:
containers:
- name: manager
args:
- --metrics-bind-addr=0.0.0.0:8080
- --feature-gates=ClusterTopology=true,KubeadmBootstrapFormatIgnition=true
- --watch-filter={{ .Values.watchFilter }}
- --v=0
image: '{{.Values.images.domain}}/{{.Values.images.controlplane.name}}:{{.Values.images.controlplane.tag | default .Values.images.tag}}'
51 changes: 0 additions & 51 deletions config/helm/deployment-args.yaml

This file was deleted.

7 changes: 7 additions & 0 deletions config/helm/deployment-labels-controller-manager.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-controller-manager
namespace: capi-system
labels:
app.kubernetes.io/component: cluster-api
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-bootstrap-controller-manager
namespace: capi-kubeadm-bootstrap-system
labels:
app.kubernetes.io/component: bootstrap-kubeadm
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-control-plane-controller-manager
namespace: capi-kubeadm-control-plane-system
labels:
app.kubernetes.io/component: control-plane-kubeadm
24 changes: 0 additions & 24 deletions config/helm/deployment-labels.yaml

This file was deleted.

14 changes: 14 additions & 0 deletions config/helm/deployment-metrics-port-controller-manager.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-controller-manager
namespace: capi-system
spec:
template:
spec:
containers:
- name: manager
ports:
- containerPort: 8080
name: metrics
protocol: TCP
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-bootstrap-controller-manager
namespace: capi-kubeadm-bootstrap-system
spec:
template:
spec:
containers:
- name: manager
ports:
- containerPort: 8080
name: metrics
protocol: TCP
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: capi-kubeadm-control-plane-controller-manager
namespace: capi-kubeadm-control-plane-system
spec:
template:
spec:
containers:
- name: manager
ports:
- containerPort: 8080
name: metrics
protocol: TCP
Loading

0 comments on commit b36c339

Please sign in to comment.