Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extra ignore file for nancy checks #385

Merged
merged 3 commits into from
Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed
- Update `architect` version to [`v6.6.0`](https://github.com/giantswarm/architect/releases/tag/v6.6.0).
- Update `nancy` to `v1.0.37`.
- Use an additional nancy exclude vulnerabilities file at the root of the repositories: `.nancy-ignore.generated`. If the file does not exist, nancy will ignore it. The standard `.nancy-ignore` file should contain the repository specific excludes and `.nancy-ignore.generated` is a generated one that should contain globally ignored vulnerabilities, if any.

## [4.23.0] - 2022-06-22

### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/commands/go-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ steps:
- run: |
CGO_ENABLED=0 golangci-lint run -E gosec -E goconst
- run: |
CGO_ENABLED=0 go list -json -m all | nancy sleuth --skip-update-check --quiet --exclude-vulnerability-file ./.nancy-ignore
CGO_ENABLED=0 go list -json -m all | nancy sleuth --skip-update-check --quiet --exclude-vulnerability-file ./.nancy-ignore --additional-exclude-vulnerability-files ./.nancy-ignore.generated
- run: |
CGO_ENABLED=0 go test -ldflags "$(cat .ldflags)" ./...
2 changes: 1 addition & 1 deletion src/executors/architect.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
docker:
- entrypoint: /bin/bash
image: quay.io/giantswarm/architect:6.4.0
image: quay.io/giantswarm/architect:6.6.0