Skip to content

Conversation

@hellt
Copy link
Contributor

@hellt hellt commented Dec 17, 2025

Hi @giancarlo3g
check out the proposed changes. Feel free to left comments in diff over the lines you want to discuss the proposals

Copilot AI review requested due to automatic review settings December 17, 2025 15:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request focuses on formatting and cleanup of ContainerLab topology and gNMIc telemetry configuration files. The changes streamline the configuration by removing unused elements and standardizing formatting conventions.

  • Removes management network configuration, default kind settings, and nokia_sros kind definition from the topology
  • Changes the nokia_srsim image reference from a full registry path to a local reference
  • Standardizes whitespace, comment formatting, and removes trailing spaces throughout both configuration files

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
topo.clab.yml Removes mgmt network config, defaults section, and nokia_sros kind; changes image reference to local format; standardizes comment spacing and removes trailing whitespace
tele-config/gnmic.yaml Removes copyright/license headers; standardizes comment formatting and whitespace; removes docker.sock bind mount reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,25 +1,16 @@
name: srv6
prefix: ""
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The management network configuration has been removed, which means the topology will use ContainerLab's default management network settings. This could break existing deployments that rely on the 'net3' network name or the specific IPv4 subnet '172.20.20.0/24'. All nodes still reference static IPs in this subnet (e.g., 172.20.20.102), which may conflict if the default network uses a different subnet.

Suggested change
prefix: ""
prefix: ""
mgmt:
network: net3
ipv4-subnet: 172.20.20.0/24

Copilot uses AI. Check for mistakes.
topology:
defaults:
kind: nokia_sros
kinds:
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'nokia_sros' kind configuration and the 'defaults' section have been removed. This removes the fallback configuration for any nodes that may have been using 'nokia_sros' as their kind. If any nodes in the topology were implicitly using the default kind 'nokia_sros', they will no longer have a valid configuration.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@giancarlo3g giancarlo3g merged commit 9fc2c2a into giancarlo3g:main Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants