-
Notifications
You must be signed in to change notification settings - Fork 1
Format topo and gnmic config #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request focuses on formatting and cleanup of ContainerLab topology and gNMIc telemetry configuration files. The changes streamline the configuration by removing unused elements and standardizing formatting conventions.
- Removes management network configuration, default kind settings, and nokia_sros kind definition from the topology
- Changes the nokia_srsim image reference from a full registry path to a local reference
- Standardizes whitespace, comment formatting, and removes trailing spaces throughout both configuration files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| topo.clab.yml | Removes mgmt network config, defaults section, and nokia_sros kind; changes image reference to local format; standardizes comment spacing and removes trailing whitespace |
| tele-config/gnmic.yaml | Removes copyright/license headers; standardizes comment formatting and whitespace; removes docker.sock bind mount reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,25 +1,16 @@ | |||
| name: srv6 | |||
| prefix: "" | |||
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The management network configuration has been removed, which means the topology will use ContainerLab's default management network settings. This could break existing deployments that rely on the 'net3' network name or the specific IPv4 subnet '172.20.20.0/24'. All nodes still reference static IPs in this subnet (e.g., 172.20.20.102), which may conflict if the default network uses a different subnet.
| prefix: "" | |
| prefix: "" | |
| mgmt: | |
| network: net3 | |
| ipv4-subnet: 172.20.20.0/24 |
| topology: | ||
| defaults: | ||
| kind: nokia_sros | ||
| kinds: |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'nokia_sros' kind configuration and the 'defaults' section have been removed. This removes the fallback configuration for any nodes that may have been using 'nokia_sros' as their kind. If any nodes in the topology were implicitly using the default kind 'nokia_sros', they will no longer have a valid configuration.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Hi @giancarlo3g
check out the proposed changes. Feel free to left comments in diff over the lines you want to discuss the proposals