Revive environ windows #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| OUT PMEMORY_BASIC_INFORMATION64 MemoryInformation, | ||
| IN ULONG64 Size, | ||
| OUT PULONG64 ReturnLength OPTIONAL); | ||
|
|
|
This is cool! I like the "enum" refactoring you applied. I just added a bunch of stylistic comments but the rest LGTM. Feel free to merge it after you address them. |
|
Thanks! I'll post an update later 💤 |
added 2 commits
January 29, 2016 12:38
Rename psutil_get_parameter to psutil_get_process_data and let it return only the data to the caller. This reduces the needed local variables and makes the function slightly simpler.
fbenkstein
force-pushed
the
revive-environ-windows
branch
from
30b775b to
6694832
Compare
fbenkstein
force-pushed
the
revive-environ-windows
branch
from
6694832 to
302a632
Compare
fbenkstein
force-pushed
the
revive-environ-windows
branch
from
302a632 to
6fe1544
Compare
|
Please have another look. |
|
All good. Merged. Thanks for the great work. |
|
@fbenkstein psutil 4.0.0 is out and I gave you credits for this great piece of code http://grodola.blogspot.com/2016/02/psutil-4-real-process-memory-and-environ.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this could be ready now. Getting the 32bit -> 64bit accesses was a pain but it appears to be working now. Unfortunately, NtWow64QueryVirtualMemory64 appears to be missing from Windows 10. So Process.environ() will throw NotImplementedError there when accessing a 64bit process from 32bit Python.