Fix macOS Python 2.7 build #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Python 2.7 tests & builds were run twice for Linux instead. Swap configuration to macOS 10.15, in par with Python 3 workflow, and to make Process.environ tests pass (broken in macOS 11+). Signed-off-by: Ben Raz <ben9923@gmail.com>
This was referenced Sep 19, 2022
|
Good catch. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Messing around with the CI build workflows I noticed something weird with the macOS Python 2.7 builds, being affected from Linux test issues.
Looking deeper I saw the macOS job is actually building & testing Linux wheels... 😝
I've set the macOS version to 10.15 like the Python 3 jobs, as apparently macOS 11+ breaks
environAPIs (There's an open issue for it inpsutil, should probably be documented).