Add Windows support to /scripts/top.py #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows with Python 3, os does not have a 'getloadavg' method. To work around this, we should simply omit the "Load average" field from the header if the 'getloadavg' is not found.
Windows uses a priroity like 'Normal' to communicate a process's
niceness rather than a number. When running top.py on Windows, the
niceness was coming through as a Priority enum which was cast to
a string like 'Priority.NORMAL_PRIORITY_CLASS', completely destroying
the column widths.
This commit addresses the issue like so:
- A new function 'niceness2priority' was added which will return a
more output-firendly word like 'Normal' or 'Idle' on Windows and
the niceness on Linux.
- The NI column will become the PRI column on Windows.
On Windows systems, Ctrl+C is implemented differently, and does not allow the user to terminate the application. This commit addresses the issue by adding a thread which watches for user input and exits the application if 'q' or Ctrl+C is entered. Tested in: - Python 3.6 (Windows) - Python 3.6 (Linux) - Python 2.7 (Linux)
Commit 339349e failed to allow 'q' and Ctrl+C to exit on Windows in new terminals. Once the python process was terminated, subsequent executions of the application were able to exit on user input as expected, which is why it was missed in testing. The issue did not affect Linux. This commit adds better 'q' and Ctrl+C to quit support for Windows and Linux.
|
Hello. scripts/top.py is not supposed to work on Windows because |
|
@giampaolo Yes, on Windows 10 with Python 3.7 installed, I am able to run |
|
(looking back at this 4 years later) I'm going to reject this because it adds too much complexity for little value (IMO). Scripts in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I realize that the files in /scripts are examples and not critical parts of the project, I feel that it's important for examples of a cross-platform library to themselves be cross-platform. This PR addresses the following Windows compatibility issues with /scripts/top.py: