Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal classes to construct psalm object #9

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Use internal classes to construct psalm object #9

merged 12 commits into from
Jul 27, 2023

Conversation

ghostwriter
Copy link
Owner

Resolves #7

@ghostwriter
Update composer.json
5bd2cfc 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update composer.lock
155a78b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update ProjectRootDirectory.php
b90c86f 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update ExpectationsJsonFile.php
838fee8 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update PsalmXmlFile.php
11659bd 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update PluginTester.php
2257b92 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update PluginTestResult.php
7a6c171 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update Expectation.php
20c15ec 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update psalm-baseline.xml
d6884ef 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update test fixtures to include severity
68d3cc5 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter linked an issue Jul 27, 2023 that may be closed by this pull request
Use internal classes to construct Psalm object #7
Closed
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #9 (351170b) into main (b3e5483) will decrease coverage by 2.01%.
The diff coverage is 87.32%.

@@             Coverage Diff              @@
##               main       #9      +/-   ##
============================================
- Coverage     36.74%   34.74%   -2.01%     
  Complexity      135      135              
============================================
  Files            20       20              
  Lines           449      472      +23     
============================================
- Hits            165      164       -1     
- Misses          284      308      +24
Files Changed Coverage Δ
src/Path/Directory/ProjectRootDirectory.php 23.37% <ø> (-2.60%) ⬇️
src/Path/File/PsalmXmlFile.php 11.76% <25.00%> (+11.76%) ⬆️
src/Value/Expectation.php 37.50% <50.00%> (-0.60%) ⬇️
src/PluginTester.php 60.21% <88.88%> (+1.17%) ⬆️
src/PluginTestResult.php 68.05% <96.87%> (+6.76%) ⬆️
src/Path/File/ExpectationsJsonFile.php 83.33% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ghostwriter
Update psalm-baseline.xml
35e1f14 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update composer.json
351170b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter merged commit 6f3184c into main Jul 27, 2023
27 of 28 checks passed
@ghostwriter ghostwriter deleted the feature/use-internal-classes-to-construct-psalm-object branch July 29, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use internal classes to construct Psalm object
1 participant
@ghostwriter