Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle circular references #5

Merged
merged 18 commits into from
Sep 5, 2024
Merged

Conversation

ghostwriter
Copy link
Owner

This patch resolves #4 , via the following changes:

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added the enhancement New feature or request label Sep 5, 2024
@ghostwriter ghostwriter added this to the 0.1.3 milestone Sep 5, 2024
@ghostwriter ghostwriter self-assigned this Sep 5, 2024
@ghostwriter ghostwriter linked an issue Sep 5, 2024 that may be closed by this pull request
@ghostwriter ghostwriter changed the title Detect circular references Handle circular references Sep 5, 2024
@ghostwriter ghostwriter merged commit e8a52be into main Sep 5, 2024
12 checks passed
@ghostwriter ghostwriter deleted the feature/detect-circular-references branch September 5, 2024 17:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 80.90909% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.20%. Comparing base (0de6d8d) to head (45c9099).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Builder.php 79.38% 20 Missing ⚠️
src/Lexer.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
- Coverage     83.33%   81.20%   -2.13%     
- Complexity       14       38      +24     
============================================
  Files             3        4       +1     
  Lines            78      149      +71     
============================================
+ Hits             65      121      +56     
- Misses           13       28      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect circular references
2 participants