Add tab title renaming feature to macos #4217

aswinmprabhu · 2024-12-31T20:03:40Z

Tries to resolve #2509 partially by enabling tab title renaming feature for MacOS.

Used the existing set_title action
Added the set_title action to Bindings so that a keybind can be set for this feature (defaulted this to cmd+i -- same as iTerm2)
3 ways to trigger this feature: "Set Title" option in the right-click menu for the window, "Set Title" option in the "View" menu in the title bar, and the keybind (cmd+i default)
Prevented esc sequences from the different programs from resetting the tab title once it is set manually using a new state var called titleSetManually in the SurfaceView
The input box is a basic native macos dialog with "OK" and "Cancel". Leaving the title text box empty resets the title to automatic / from the title property in the config

Demo:

Screenshare.-.2025-01-01.12_59_47.AM.1.mp4

Need some feedback. Thanks!

qwerasd205 · 2024-12-31T21:04:23Z

Haven't reviewed the code, but the demo looks good. I'd prefer if the UI were in a popover that drops down from the tab title, but that can come later, this is fine as it is.

macos/Sources/Ghostty/SurfaceView_AppKit.swift

francescarpi · 2025-01-01T11:05:08Z

I love this feature! It would also be nice to be able to change the title by double-clicking the tab title. This could be addressed in a separate PR, depending on the difficulty.
Thanks!

mitchellh · 2025-02-14T21:20:14Z

Sorry for the delay! Great work with this. I made some modifications that I felt were important:

SurfaceView keeps track of the last title libghostty sent, so when we reset the title we can immediately set it to the correct value. Previously, it waited for the next.
The above also removes the reload_config which we shouldn't ever call unless the config actually wants to be reloaded.
I changed the binding action to change_title_prompt
I also made an apprt action this can trigger

jcollie · 2025-02-14T21:23:29Z

I'm going to bikeshed this a bit but what's the rationale for some things being called set_title_prompt and some things being called change_title_prompt. Also why is "prompt" part of the verb anyway? We're not changing a prompt. IMHO, there should be a keybind called "prompt_for_tab_title" that pops up a dialog box, and an apprt action called "set_tab_title" that performs the change.

mitchellh · 2025-02-14T21:24:55Z

I'm going to bikeshed this a bit but what's the rationale for some things being called set_title_prompt and some things being called change_title_prompt

Yeah I will unify this.

Also why is "prompt" part of the verb anyway?

Because the user is being prompted

IMHO, there should be a keybind called "prompt_for_tab_title" that pops up a dialog box, and an apprt action called "set_tab_title" that performs the change.

Note this is actually unrelated to tabs. These are surface titles.

jcollie · 2025-02-14T21:25:47Z

Because the user is being prompted

Then it should be prompt... and not set_...

mitchellh · 2025-02-14T21:26:36Z

Then it should be prompt... and not set_...

I'm good with this

mitchellh · 2025-02-14T21:30:58Z

Renamed. The macOS details are still named changeTitle and so on since that aligns with the menu item and makes more sense. It's more confusing at the core config level to use "change" because I could foresee bindings to change it to a preset value vs prompting. In a GUI prompting is implied in various ways, such as with the ellipses on the menu item, being a GUI interaction, etc.

mdznr

The ellipsis character should be used in menu items like these

https://support.apple.com/guide/applestyleguide/e-apsg076a7313/1.0/web/1.0#apd4768067dad604

mdznr · 2025-02-20T04:28:14Z

macos/Sources/App/macOS/MainMenu.xib

                                </connections>
                            </menuItem>
                            <menuItem isSeparatorItem="YES" id="L3L-I8-sqk"/>
+                            <menuItem title="Change Title..." id="24I-xg-qIq">


Suggested change

<menuItem title="Change Title..." id="24I-xg-qIq">

<menuItem title="Change Title…" id="24I-xg-qIq">

mdznr · 2025-02-20T04:28:33Z

macos/Sources/Ghostty/SurfaceView_AppKit.swift

            menu.addItem(withTitle: "Reset Terminal", action: #selector(resetTerminal(_:)), keyEquivalent: "")
            menu.addItem(withTitle: "Toggle Terminal Inspector", action: #selector(toggleTerminalInspector(_:)), keyEquivalent: "")
+            menu.addItem(.separator())
+            menu.addItem(withTitle: "Change Title...", action: #selector(changeTitle(_:)), keyEquivalent: "")


Suggested change

menu.addItem(withTitle: "Change Title...", action: #selector(changeTitle(_:)), keyEquivalent: "")

menu.addItem(withTitle: "Change Title…", action: #selector(changeTitle(_:)), keyEquivalent: "")

mvolkmann · 2025-03-16T13:22:55Z

This issue is marked as merged, but I have version 1.1.2 and when I right-click in a split in macOS I don't see the "Set Title" menu option. Is this change currently available for macOS?

mitchellh · 2025-03-16T13:45:49Z

No it’s on tip. See the milestone this got attached to

felipevolpone · 2025-04-15T22:01:59Z

I'm on tip, but I'm not able to setup a keybind for this. I've tried:

keybind = cmd+i=change_title_prompt

but when I reload the config, I get the keybind: unknown error error.InvalidAction error.
Am I missing something?

00-kat · 2025-04-16T00:40:11Z

It's not change_title_prompt anymore, you want prompt_surface_title.

00-kat · 2025-04-16T00:40:54Z

macos/Sources/App/macOS/AppDelegate.swift

        syncMenuShortcut(config, action: "increase_font_size:1", menuItem: self.menuIncreaseFontSize)
        syncMenuShortcut(config, action: "decrease_font_size:1", menuItem: self.menuDecreaseFontSize)
        syncMenuShortcut(config, action: "reset_font_size", menuItem: self.menuResetFontSize)
+        syncMenuShortcut(config, action: "change_title_prompt", menuItem: self.menuChangeTitle)


This line is very suspicious though (it's still like this on the current main); every other instance is prompt_surface_title. (Corrected in #7149.)

felipevolpone · 2025-04-16T11:44:31Z

Thanks, that made it 🙌

One small feedback [1]: At least in mac os, when the popup appears the focus of the cursor is not on the text field, but on the "Cancel" button, which is kinda weird.

Not sure if it's possible to see with this screenshot:

[1] If this is not the place for it, I'm happy to open an issue for it.

00-kat · 2025-04-16T11:46:55Z

Yeah, open a new Discussion.

felipevolpone · 2025-04-16T12:08:54Z

For reference: #7105

This was changed pretty late at #4217 (comment), and I don't think anybody saw my comment at #4217 (comment); I have no idea if this change is correct and have no way to test it either as I don't use macOS, but I'm quite suspicious of that line having not been changed.

SachaG · 2025-06-25T00:37:57Z

I'm running version 1.1.3 and not seeing a way to trigger the dialog. Has this been rolled back since? Is this feature documented anywhere?

jcollie · 2025-06-25T01:24:45Z

I'm running version 1.1.3 and not seeing a way to trigger the dialog. Has this been rolled back since? Is this feature documented anywhere?

It is not part of 1.1.3 or any other released version. It will be part of 1.2 when it is released. Please read the comments more carefully before commenting on such an old closed PR.

SachaG · 2025-06-25T01:58:57Z

@jcollie sorry but it's not obvious which release this feature is attached to at first glance, so I think given that the PR was approved a couple months ago it's reasonable to assume the feature might already be part of the latest public release. Looking forward to 1.2 though :)

jcollie · 2025-06-25T02:04:40Z

@jcollie sorry but it's not obvious which release this feature is attached to at first glance, so I think given that the PR was approved a couple months ago it's reasonable to assume the feature might already be part of the latest public release. Looking forward to 1.2 though :)

Check the "milestone" that this PR is attached to. It's up near the top on the right. It's even mentioned in a comment above.

mitchellh · 2025-06-25T02:04:41Z

You can always tell where an issue or PR made it via this. This is managed by CI.

jbayer reviewed Jan 1, 2025

View reviewed changes

macos/Sources/Ghostty/SurfaceView_AppKit.swift Outdated Show resolved Hide resolved

mitchellh force-pushed the bgimage branch from 64f294e to 04a364b Compare February 14, 2025 21:10

mitchellh requested review from a team as code owners February 14, 2025 21:10

mitchellh force-pushed the bgimage branch from 04a364b to ad87dbf Compare February 14, 2025 21:18

mitchellh approved these changes Feb 14, 2025

View reviewed changes

mitchellh previously approved these changes Feb 14, 2025

View reviewed changes

Add tab title rename feature to macos

a581955

mitchellh dismissed their stale review via a581955 February 14, 2025 21:29

mitchellh force-pushed the bgimage branch from ad87dbf to a581955 Compare February 14, 2025 21:29

mitchellh mentioned this pull request Feb 14, 2025

macOS: "Change Title" feature should use a popover instead of an NSAlert #5768

Closed

mitchellh merged commit 1121ea9 into ghostty-org:main Feb 14, 2025
29 checks passed

github-actions bot added this to the 1.2.0 milestone Feb 14, 2025

This was referenced Feb 14, 2025

GTK: Add "Change Title" feature #5769

Closed

Feature Request: ability to set title and colour of a tab #2509

Closed

mdznr reviewed Feb 20, 2025

View reviewed changes

00-kat reviewed Apr 16, 2025

View reviewed changes

00-kat mentioned this pull request Apr 21, 2025

Correct change_title_prompt → prompt_surface_title #7149

Merged

mitchellh mentioned this pull request Jul 14, 2025

macOS: Rename Tab Title popup focuses incorrect control with "Keyboard navigation" system setting #7940

Closed

pluiedev mentioned this pull request Jan 16, 2026

copy_title_to_clipboard copies original terminal title instead of manually renamed title #10345

Open

3 tasks

	<menuItem title="Change Title..." id="24I-xg-qIq">
	<menuItem title="Change Title…" id="24I-xg-qIq">

	menu.addItem(withTitle: "Change Title...", action: #selector(changeTitle(_:)), keyEquivalent: "")
	menu.addItem(withTitle: "Change Title…", action: #selector(changeTitle(_:)), keyEquivalent: "")

Add tab title renaming feature to macos #4217

Add tab title renaming feature to macos #4217

Conversation

aswinmprabhu commented Dec 31, 2024

Uh oh!

qwerasd205 commented Dec 31, 2024

Uh oh!

Uh oh!

francescarpi commented Jan 1, 2025

Uh oh!

mitchellh commented Feb 14, 2025

Uh oh!

jcollie commented Feb 14, 2025

Uh oh!

mitchellh commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcollie commented Feb 14, 2025

Uh oh!

mitchellh commented Feb 14, 2025

Uh oh!

mitchellh commented Feb 14, 2025

Uh oh!

Uh oh!

mdznr left a comment

Choose a reason for hiding this comment

Uh oh!

mdznr Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

mdznr Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

mvolkmann commented Mar 16, 2025

Uh oh!

mitchellh commented Mar 16, 2025

Uh oh!

felipevolpone commented Apr 15, 2025

Uh oh!

00-kat commented Apr 16, 2025

Uh oh!

00-kat Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felipevolpone commented Apr 16, 2025

Uh oh!

00-kat commented Apr 16, 2025

Uh oh!

felipevolpone commented Apr 16, 2025

Uh oh!

SachaG commented Jun 25, 2025

Uh oh!

jcollie commented Jun 25, 2025

Uh oh!

SachaG commented Jun 25, 2025

Uh oh!

jcollie commented Jun 25, 2025

Uh oh!

mitchellh commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

mitchellh commented Feb 14, 2025 •

edited

Loading

00-kat Apr 16, 2025 •

edited

Loading