Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github pages #15

Merged
merged 1 commit into from
May 16, 2023
Merged

Add github pages #15

merged 1 commit into from
May 16, 2023

Conversation

kaiix
Copy link
Collaborator

@kaiix kaiix commented May 16, 2023

Closes #14

This change will run an action to build static site and push it to branch gh-pages, the pages setting should set to this branch.

The project site will appear on https://ghostincoolshell.github.io/haoel-articles

@kaiix kaiix requested a review from hongqn May 16, 2023 03:23
@hongqn
Copy link
Contributor

hongqn commented May 16, 2023

直接从 rss2html 能 serve 吗?

@kaiix
Copy link
Collaborator Author

kaiix commented May 16, 2023

直接从 rss2html 能 serve 吗?

可以, 但用 mkdocs 构造静态站更加便捷. HTML 和 markdown 都是从 rss feed 中提取的, 信息量上没有差别.

另外, 应该考虑下 #12, 衍生数据不用直接作为代码保存了.

@hongqn
Copy link
Contributor

hongqn commented May 16, 2023

另外, 应该考虑下 #12, 衍生数据不用直接作为代码保存了.

但我看这个 pr 的实现是依赖 rss2html2markdown 目录存在的?

我的想法是,release 包并不是必要的(也不太好有 release version 的概念),如果有 github pages 可以提供直接访问,那么仓库中只需要保留转化脚本即可。

@hongqn hongqn merged commit 31c0b9b into ghostincoolshell:main May 16, 2023
@kaiix
Copy link
Collaborator Author

kaiix commented May 16, 2023

另外, 应该考虑下 #12, 衍生数据不用直接作为代码保存了.

但我看这个 pr 的实现是依赖 rss2html2markdown 目录存在的?

我的想法是,release 包并不是必要的(也不太好有 release version 的概念),如果有 github pages 可以提供直接访问,那么仓库中只需要保留转化脚本即可。

可以不依赖 rss2html2markdown, markdown 仅在 (action) build 过程中出现. 当然, 最终静态文件都会 push 到 gh-pages branch.

@kaiix kaiix deleted the static branch May 16, 2023 06:07
@hongqn hongqn mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve the blog in github pages
2 participants