fix(adblocker): match logic between onHeadersReceived and onBeforeRequest #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalluban
force-pushed
the
fix-adblocker
branch
from
27ff437
to
4fb1fd3
Compare
smalluban
force-pushed
the
fix-adblocker
branch
from
4fb1fd3
to
7424859
Compare
chrmod
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR matches the logic of the
onHeadersReceivedlistener with theonBeforeRequest.ghostery-extension/src/background/adblocker.js
Line 469 in 075cdd4
The issue was found with the managed state of the extension. Requests to update the engines generate error logs, as there is no way that the engine is ready yet.