Fix the TrackerDB metainformation domain lookup #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, the request to https://global.ketchcdn.com/web/v3/config/avant/website_smart_tag/boot.js has hostname=global.ketchcdn.com and domain=ketchcdn.com The current TrackerDB entry is for "global.ketchcdn.com", so the lookup by domain does not return a result. The adblocker implementation will still do a lookup for the parent domain. So, it will also try out "ketchcdn.com". Because of that, there should be no need to fallback to the (parent) domain in the extension.
philipp-classen
force-pushed
the
use_full_domain_for_trackerdb_matching
branch
from
d07fb56
to
7347ff4
Compare
chrmod
approved these changes
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include also the subdomain information when doing a TrackerDB lookup.
For instance, the request to
https://global.ketchcdn.com/web/v3/config/avant/website_smart_tag/boot.jshashostname=global.ketchcdn.com and domain=ketchcdn.com
The current TrackerDB entry is for "global.ketchcdn.com", so the lookup by domain does not return a result. The adblocker implementation will still do a lookup for the parent domain. So, it will also try out "ketchcdn.com". Because of that, there should be no need to fallback to the (parent) domain in the extension.
Test page: https://www.avantassessment.com/
This is the lookup code in the adblocker: https://github.com/ghostery/adblocker/blob/5f04d7ae0cdbdfd569ed8a9bcd14cf916f026aa1/packages/adblocker/src/engine/metadata.ts#L173
It will start with the most specific subdomain and work its way up. So, the caller can safely pass the subdomain; it will still do the lookup for the parent.