Fix missing telemetry fields #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-classen
previously approved these changes
Sep 5, 2024
smalluban
requested changes
Sep 6, 2024
chrmod
commented
Sep 6, 2024
Comment on lines
+59
to
+61
| installDate: | ||
| options.installDate || new Date().toISOString().split('T')[0], | ||
| installRandom: Math.floor(Math.random() * 100) + 1, |
There was a problem hiding this comment.
those are now part of the telemetry storage instead of options
| if (!storage.installDate) { | ||
| saveStorage(storage, { | ||
| installDate: | ||
| options.installDate || new Date().toISOString().split('T')[0], |
There was a problem hiding this comment.
That part still confuses me: why there is a fallback to options for installDate, but not for the random number. It is not obvious to me, why we need the fallback here? If storage.installDate is not present, how can options have it?
There was a problem hiding this comment.
If I understand correctly, options.installDate is migration code? And installRandom did not exist before.
If so, could we leave a comment that "options.installDate || " exists to migrate data from old clients? And that we could eventually remove it?
smalluban
approved these changes
Sep 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those data points were always a part of the minimalistic telemetry signals that were used in Ghostery 8.