fix: detect redirected requests from DNR rules #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1712
This PR adds feedback for redirect DNR rules for Chromium-based browsers.
After the investigation and initial implementation using engines, I found a simpler and clearer solution.
The only platform left is Safari. The initial idea still works (I have proven it to myself), but I think it is not worth implementing it just for Safari.
The idea is to serve full adblocker engines (with network filters) and for Safari when we gather the stats, we could run again through all of the engines to check if there are redirect rules. If so, we likely have a DNR rule for that. Then we can assume that this request was redirected (but this is at most, an assumption).