$replace modifier #1842
Merged
$replace modifier #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmod
force-pushed
the
firefox-$replace
branch
from
9d48191
to
88592e3
Compare
chrmod
added
Ad-Blocking
Co-authored-by: Philipp Claßen <philipp@ghostery.com>
philipp-classen
previously approved these changes
Aug 30, 2024
|
Update: For YouTube, we found a problems with the new adblocker version ( |
Smoke tests Iteration no 1:Tests of: #1842 (comment) Checked features:
Issues:Fixed:Cannot reproduce:Will not be fixed: |
philipp-classen
approved these changes
Sep 5, 2024
smalluban
approved these changes
Sep 5, 2024
| }, | ||
| { urls: ['<all_urls>'], types: ['main_frame'] }, | ||
| { urls: ['http://*/*', 'https://*/*'] }, |
There was a problem hiding this comment.
Shouldn't we add the same constraint on other even listeners? I found a case where we have a callback for our own background page in Firefox (Navigation API) when Dev Tools are opened.
Sometimes I have an error in Chrome, that shows that page from chrome:// can't be accessed.
There was a problem hiding this comment.
good point, and it is unclear if onBeforeRequest should process <all_urls> or only http* and ws*.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires ghostery/adblocker#4241
To test basic use-case, try this custom filter
example.com$replace=/Example Domain/Hello from Ghostery/gat example.comNotice that both
<title>and<h1>got updated.This have to be carefully tested on youtube.com once the
$replacefilters are enabled.