-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom filters #1813
Refactor custom filters #1813
Conversation
@philipp-classen Updated and fixed what I could change. The |
@GRadziejewski Testing highlights:
|
Test results: #1822 (comment) Issue: #1823 |
After testing the feature, I added a small change to not confuse users - the "Update" (actually "Save" now - it's more what it is, and it's already translated phrase) is disabled only when filters update. |
Test results: #1822 LGTM. |
Moves the generation logic and fixes some minor bugs of the custom filters feature.
options.customFilters.enabled
property and on/off feature of the custom filters without the need to remove the whole textarea content to temporarily disable custom filterscomponents/custom-filters.js
file - as this should be a component, not a file with that much logic, which is not related to the UII tried to not change the logic, but in some places, it looked to me like obvious bugs - please review this code not as an update, but as a whole - if this works as you would expected it to work.