Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing space in partition.py #77

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fixed missing space in partition.py #77

merged 1 commit into from
Nov 15, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 15, 2024

Summary by Sourcery

Bug Fixes:

  • Fix missing space in conditional statement in partition.py to ensure correct logical evaluation.

@ericbsd ericbsd requested review from a team as code owners November 15, 2024 11:33
Copy link

sourcery-ai bot commented Nov 15, 2024

Reviewer's Guide by Sourcery

This is a simple fix that adds a missing space in a conditional statement within the partition selection logic. The change improves code readability without affecting functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed a syntax formatting issue in partition selection condition
  • Added a missing space between the number 2 and the 'and' keyword in the conditional statement
src/partition.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a code formatter (like black, autopep8, or yapf) to prevent spacing issues in the future.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 6f3d634 into master Nov 15, 2024
2 checks passed
@ericbsd ericbsd deleted the fix-partiotn.py branch November 15, 2024 11:34
@ericbsd ericbsd self-assigned this Nov 16, 2024
@ericbsd ericbsd added the bug label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant