Skip to content

fix(grid): force top row offset for RowDetail in transform mode - #2722

Merged
ghiscoding merged 1 commit into
masterfrom
bugfix/fallback-transform-top
Aug 11, 2026
Merged

fix(grid): force top row offset for RowDetail in transform mode#2722
ghiscoding merged 1 commit into
masterfrom
bugfix/fallback-transform-top

Conversation

@ghiscoding

Copy link
Copy Markdown
Owner

Description

This change makes RowDetail rendering safer by automatically switching row offset rendering to top when transform is configured. The goal is to prevent known visual issues while keeping behavior stable and minimal.

High-level updates:

  1. Keep RowSpan warning behavior in init.
  2. Enforce RowDetail fallback from transform to top during option validation.
  3. Remove duplicate warning noise from the new fallback path.
  4. Update and align unit tests with the final behavior.

Validation:

  1. Targeted core SlickGrid specs pass.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (144cc05) to head (4c9e000).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2722   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25542    25544    +2     
  Branches     9030     9031    +1     
=======================================
+ Hits        25542    25544    +2     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2722

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2722

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2722

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2722

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2722

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2722

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2722

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2722

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2722

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2722

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2722

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2722

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2722

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2722

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2722

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2722

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2722

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2722

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2722

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2722

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2722

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2722

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2722

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2722

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2722

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2722

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2722

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2722

commit: 4c9e000

@ghiscoding
ghiscoding merged commit 6fdc7d6 into master Aug 11, 2026
12 checks passed
@ghiscoding
ghiscoding deleted the bugfix/fallback-transform-top branch August 11, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant