Skip to content

feat(services): pluralize CRUD events (ie: onItemsAdded, ...) - #1910

Merged
ghiscoding merged 3 commits into
nextfrom
feat/pluralize-crud-events
Apr 11, 2025
Merged

feat(services): pluralize CRUD events (ie: onItemsAdded, ...)#1910
ghiscoding merged 3 commits into
nextfrom
feat/pluralize-crud-events

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Apr 11, 2025

Copy link
Copy Markdown
Owner

Our GridService has CRUD event that was sometime returning a single item or sometime multiple items and for that reason we had to rely on code like onItemAdded.subscribe(item => { const items = Array.isArray(item) ? item : [item] }, but if we always return an array then we know exactly the shape of items.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov

codecov Bot commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (87823a9) to head (52c5249).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1910   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         187      187           
  Lines       34517    34517           
  Branches    10280    10279    -1     
=======================================
  Hits        34491    34491           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding
ghiscoding merged commit b776b1b into next Apr 11, 2025
@ghiscoding
ghiscoding deleted the feat/pluralize-crud-events branch April 11, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant