fix: improve build & types exports for all targets, Node, CJS/ESM #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 245 245
Lines 17271 17271
Branches 6244 6244
=========================================
Hits 17271 17271 |
ghiscoding
changed the title
ghiscoding
changed the title
Owner
Author
|
Much better after releasing a new version with this change :)
|
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Nov 13, 2023
- update to latest Slickgrid-Universal which has the following 2 changes 1. add missing `@types/trusted-types` deps, fixes issue #1313 2. Slickgrid-Universal has improved types exports for TS Types discovery as can be shown in its [PR 1188](ghiscoding/slickgrid-universal#1188) and [Are the types wrong?](https://arethetypeswrong.github.io/?p=%40slickgrid-universal%2Fcommon%403.5.1) website
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Nov 13, 2023
- update to latest Slickgrid-Universal which has the following 2 changes 1. add missing `@types/trusted-types` deps, fixes issue #1313 2. Slickgrid-Universal has improved types exports for TS Types discovery as can be shown in its [PR 1188](ghiscoding/slickgrid-universal#1188) and [Are the types wrong?](https://arethetypeswrong.github.io/?p=%40slickgrid-universal%2Fcommon%403.5.1) website
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Nov 13, 2023
- update to latest Slickgrid-Universal which has the following 2 changes 1. add missing `@types/trusted-types` deps, fixes issue #1313 2. Slickgrid-Universal has improved types exports for TS Types discovery as can be shown in its [PR 1188](ghiscoding/slickgrid-universal#1188) and [Are the types wrong?](https://arethetypeswrong.github.io/?p=%40slickgrid-universal%2Fcommon%403.5.1) website
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Nov 13, 2023
- update to latest Slickgrid-Universal which has the following 2 changes 1. add missing `@types/trusted-types` deps, fixes issue #1313 2. Slickgrid-Universal has improved types exports for TS Types discovery as can be shown in its [PR 1188](ghiscoding/slickgrid-universal#1188) and [Are the types wrong?](https://arethetypeswrong.github.io/?p=%40slickgrid-universal%2Fcommon%403.5.1) website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple-select-vanillalibrary with a much greater success