feat(core): add loading spinner to AutoComplete Editor/Filter #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Aug 5, 2020
ghiscoding
commented
- add SASS styling to use the jQuery UI loading styling (internally jQuery UI will automatically add the CSS class "ui-autocomplete-loading" whenever processing) which shows up after few milliseconds (when using remote calls)
- add SASS styling to use the jQuery UI loading styling (internally jQuery UI will automatically add the CSS class "ui-autocomplete-loading" whenever processing) which shows up after few milliseconds (when using remote calls)
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 148 148
Lines 9719 9723 +4
Branches 3274 3414 +140
==========================================
+ Hits 9719 9723 +4
Continue to review full report at Codecov.
|
ghiscoding
changed the title
ghiscoding
commented
Aug 6, 2020
| @@ -145,6 +145,12 @@ $autocomplete-border-radius: 4px !default; | |||
| $autocomplete-box-shadow: 0 6px 12px rgba(0, 0, 0, 0.175) !default; | |||
| $autocomplete-hover-color: #262626 !default; | |||
| $autocomplete-hover-bg-color: darken($row-mouse-hover-color, 3%) !default; | |||
| $autocomplete-loading-icon: "\f021" !default; | |||
| $autocomplete-loading-icon-color: inherit !default; | |||
There was a problem hiding this comment.
use $icon-color instead and also do the same for the var $header-menu-button-icon-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.