Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update sudoku exercise #23

Merged
merged 6 commits into from
Oct 2, 2021
Merged

Conversation

gguridi
Copy link
Owner

@gguridi gguridi commented Oct 2, 2021

No description provided.

- Moved from custom webpack configuration to use react-scripts to make things simpler.
- Upgraded dependencies to latest ones.
- Added linting and integration with codacy/codecov.
- Added continuous integration examples of how to run tests on push/pull requests and how to "deploy" in github pages upon release.
- Updated dockerfile to use an official node image so we don't have to install everything from scratch.
- Updated sass examples to make them more interesting.
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d04cb3b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   66.66%           
=========================================
  Files             ?        2           
  Lines             ?        3           
  Branches          ?        0           
=========================================
  Hits              ?        2           
  Misses            ?        1           
  Partials          ?        0           
Flag Coverage Δ
unittests 66.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04cb3b...856051d. Read the comment docs.

@gguridi gguridi merged commit 0969cf4 into master Oct 2, 2021
@gguridi gguridi deleted the feature/update-sudoku-exercise branch October 2, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants