Add --as-text option #1184
Open
Add --as-text option #1184
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is equivalent to the --text option in GNU Grep.
|
Ping. I use this feature all the time to reliably grep through sources that contain non-ASCII characters. |
aswild
pushed a commit
to aswild/the_silver_searcher
that referenced
this pull request
Jul 23, 2018
This is equivalent to the --text option in GNU Grep. Cherry-pick: ggreer#1184
|
Hi, really required this param, to proper search |
|
Any follow up on this? |
|
Seconding this. I was surprised to find I couldn't just rename my binary file to |
|
@murmour Thank you for MR, you saved me. Also voting for inclusion this patch into main source tree. For some reason it treats regular text files in single byte encoding as binary ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--as-textoption, which is equivalent to the--textoption in GNU Grep.Without this option,
agsometimes interprets cp1251-encoded sources as binaries. Effectively, the new option disables the binary detection heuristic, which makes perfect sense for situations whereagis asked to perform search only in files with a specific extension (corresponding to a particular language).