Skip to content

Conversation

teejae
Copy link
Contributor

@teejae teejae commented Sep 16, 2024

When doing auto convert of audio files, always generate new temporary filenames, rather than a fixed filename.

  • Allows running multiple conversions/transcriptions simultaneously without risk of overwriting files

@teejae teejae force-pushed the tj-server-temp-name branch from 1bdb5b3 to 0611b95 Compare September 16, 2024 23:24
@teejae teejae force-pushed the tj-server-temp-name branch from 0611b95 to 5e0c851 Compare September 16, 2024 23:26
@teejae teejae changed the title use tmp name server: Use OS-generated temp file name for ffmpeg converted files Sep 16, 2024
@teejae teejae marked this pull request as ready for review September 16, 2024 23:29
@ggerganov ggerganov merged commit 5b1ce40 into ggml-org:master Sep 17, 2024
45 checks passed
@teejae teejae deleted the tj-server-temp-name branch September 17, 2024 13:59
@ggerganov
Copy link
Member

I'm not super familiar with tmpnam, but I see the compiler giving the following warning:

/usr/bin/ld: examples/server/server.o: in function `main::{lambda(httplib::Request const&, httplib::Response&)#3}::operator()(httplib::Request const&, httplib::Response&) const':
server.cpp:(.text+0x4d39): warning: the use of `tmpnam' is dangerous, better use `mkstemp'

Could you propose a way to fix this warning?

iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
lyapple2008 pushed a commit to lyapple2008/whisper.cpp.mars that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants