Pass max-len argument to server wparams #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the missing parameter binding for max-len between the input arguments and wparams.
felrock
approved these changes
Dec 5, 2023
|
Thanks folks, much appreciated! |
|
🎉 Looking forward to |
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
This commit fixes the missing parameter binding for max-len between the input arguments and wparams.
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Dec 20, 2023
* origin/master: bench.py : add different large models (ggml-org#1655) wchess : update README.md release : v1.5.2 wchess : update readme wchess : whisper assisted chess (ggml-org#1595) sync : ggml (Metal fixes, new ops, tests) (ggml-org#1633) cmake : target windows 8 or above for prefetchVirtualMemory in llama-talk (ggml-org#1617) cmake : Fix bug in httplib.h for mingw (ggml-org#1615) metal : fix `ggml_metal_log` vargs (ggml-org#1606) whisper.objc : disable timestamps for real-time transcription whisper : more debug messages + fix fallback logic metal : fix soft_max kernel src1 argument (ggml-org#1602) sync : ggml (new ops, new backend, etc) (ggml-org#1602) server : pass max-len argument to the server (ggml-org#1574) ios : Remove `#if arch(arm)` check for using Metal (ggml-org#1561) ggml : Fix 32-bit compiler warning (ggml-org#1575) ggml : re-enable blas for src0 != F32 (ggml-org#1583)
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
This commit fixes the missing parameter binding for max-len between the input arguments and wparams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the missing parameter binding for max-len between the input arguments and wparams.
The major difference between examples/main and examples/server is the following:
Vs
I.e. the proposed fix does not take under consideration the
open_wtsflag as it is not backported to the server yet. I'm happy to backport wts if it could be of use, as a separate PR.