Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc : pack only RPC structs #9959

Merged
merged 1 commit into from
Oct 21, 2024
Merged

rpc : pack only RPC structs #9959

merged 1 commit into from
Oct 21, 2024

Conversation

rgerganov
Copy link
Collaborator

/cc @Green-Sky

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Oct 20, 2024
@rgerganov rgerganov mentioned this pull request Oct 20, 2024
Merged
4 tasks
Green-Sky
Green-Sky approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. Although, since you are not really using the stack, you could do without. But I guess the stack is better understandable?

@rgerganov
Copy link
Collaborator Author

With push/pop we preserve the previous value which is not important here but I guess it is still a good practice.

@rgerganov rgerganov merged commit d5ebd79 into ggml-org:master Oct 21, 2024
53 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@rgerganov @dsx1986
rpc : pack only RPC structs (ggml-org#9959)
f37cee5
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@rgerganov @arthw
rpc : pack only RPC structs (ggml-org#9959)
cd7a676
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@rgerganov @arthw
rpc : pack only RPC structs (ggml-org#9959)
dae14d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgerganov @Green-Sky